Masp vp parallel verification #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2972 +/- ##
==========================================
+ Coverage 53.89% 53.94% +0.05%
==========================================
Files 314 314
Lines 105704 105597 -107
==========================================
Hits 56968 56968
+ Misses 48736 48629 -107 ☔ View full report in Codecov by Sentry. |
grarco
force-pushed
the
grarco/masp-parallel-verification
branch
from
5dd3e6a
to
ad6b35a
Compare
Merged
grarco
force-pushed
the
grarco/masp-parallel-verification
branch
from
ad6b35a
to
5b72670
Compare
grarco
force-pushed
the
grarco/masp-parallel-verification
branch
from
2999a49
to
dea5d4b
Compare
grarco
force-pushed
the
grarco/masp-parallel-verification
branch
2 times, most recently
from
593e18a
to
b4d49d1
Compare
grarco
force-pushed
the
grarco/masp-parallel-verification
branch
from
b4d49d1
to
7cc4d90
Compare
grarco
force-pushed
the
grarco/masp-parallel-verification
branch
from
7cc4d90
to
15affec
Compare
batconjurer
approved these changes
May 28, 2024
brentstone
added a commit
that referenced
this pull request
May 28, 2024
* grarco/masp-parallel-verification: Changelog #2972 Updates masp gas costs Reworks gas metering for masp validation Fixes masp benchmarks Updates masp dep. Patch reddsa dep Updates benchmarks for parallel masp verification Run masp verification in parallel
brentstone
added a commit
that referenced
this pull request
May 30, 2024
* origin/grarco/masp-parallel-verification: Changelog #2972 Updates masp gas costs Reworks gas metering for masp validation Fixes masp benchmarks Updates masp dep. Patch reddsa dep Updates benchmarks for parallel masp verification Run masp verification in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2959.
Parallelize the masp vp verification step.
Currently this doesn't work. The parallel verification process succeeds for every check (even the proofs) except for the signature one and more specifically for the final check on the result point being of small order (https://github.com/ZcashFoundation/reddsa/blob/56d52195608f3830f027f7109176a30175a5c1aa/src/batch.rs#L272)To get batch signature verfication to work, the following three issues needed fixing:
The latter two issues are the most inconvenient. We can either change our personalization and basepoints to match the RedDSA assumptions, or we must fork that crateIndicate on which release or other PRs this topic is based on
v0.37.0
Checklist before merging to
draft